Conversation
… the different result of Aircraft.Wing.BENDING_MATERIAL_FACTOR (or BT as returned by subroutine BNDMAT) between Aviary and FLOPS.
jkirk5
left a comment
jkirk5
left a comment
There was a problem hiding this comment.
Needed update to preprocessors.py
| if engine_models is not None: | ||
| preprocess_propulsion(aviary_options, engine_models, meta_data, verbosity) | ||
|
|
||
| if Aircraft.Wing.ASPECT_RATIO_REFERENCE in aviary_options: |
There was a problem hiding this comment.
Now that fortran_to_aviary has been updated to handle the ASPECT_RATIO_REFERENCE = 0 case, this part of the preprocessor needs to be rewritten to follow the following case:
ASPECT_RATIO_REFERENCE not in aviary_options, in which case we set it to ASPECT_RATIO (and warn user)
The same goes for THICKNESS_TO_CHORD_REFERENCE
There was a problem hiding this comment.
We no longer need to check if the variable is provided and equals zero, so that code no longer needs to be here - I am basically asking for this entire section to be replaced
There was a problem hiding this comment.
Are you saying that Aircraft.Wing.ASPECT_RATIO_REFERENCE and Aircraft.Wing.THICKNESS_TO_CHORD_REFERENCE and taken care by fortran_to_aviary by a PR of someone else? They are not in this PR.
3 participants
Summary
This PR implements another BWB model from FLOPS - BWB300 baseline model.
The BWB300 baseline model implemented here is not exactly the same as the original FLOPS model. This is because Aviary did not implement all the features of FLOPS. More precisely, here are the differences:
Aircraft.Fuselage.MAX_WIDTH = 50.0is not implemented inBWBDetailedCabinLayoutcomponent. Can override later.Aircraft.Fuselage.MAX_HEIGHT = 14.16is not implemented inBWBDetailedCabinLayoutcomponent. Can override later.Aircraft.Wing.ROOT_CHORDwhich is an output fromBWBDetailedCabinLayoutcomponent. Can override later.Mission.Design.GROSS_MASS = 600,000manually. The original logic is DGW = 1, IF(DGW < 5) DG = DGW * GW, but GW is not read in to Aviary. Should we create a new Aviary variable for GW (Ramp weight)?Aircraft.Wing.GLOVE_AND_BATis not implemented. So, take the value from FLOPS run. See subroutine DEFINE().Aircraft.Wing.SPAN = 186.3is incorrect. FLOPS updates value during its run. If we input bothAircraft.Wing.SPANandAircraft.Wing.OUTBOARD_SEMISPAN, they must satisfyAircraft.Wing.SPAN Aircraft.Fuselage.MAX_WIDTH + Aircraft.Wing.OUTBOARD_SEMISPAN*2.Aircraft.Fuselage.HEIGHT_TO_WIDTH_RATIO). Should we add TCSOB (meaning Fuselage thickness/chord ratio at side of body) to Aviary? This will affect the computation ofBWB_THICKNESS_TO_CHORD_DISTRIBUTION[1].Aircraft.VerticalTail.WETTED_AREA = 125, even thoughAircraft.VerticalTail.NUM_TAILS = 0. It is ignored.aircraft:wing:aspect_ratio,5.4252,unitlessin .csv file in order to follow FLOPS computation.Aircraft.HorizontalTail.VERTICAL_TAIL_FRACTION) is not taken care byfortran_to_aviary().Aircraft.VerticalTail.SWEEP) is not taken care byfortran_to_aviary().Aircraft.VerticalTail.ASPECT_RATIO) is not taken care byfortran_to_aviary().Aircraft.VerticalTail.TAPER_RATIO) is not taken care byfortran_to_aviary().Aircraft.Fuel.WING_FUEL_CAPACITY) is not taken care byfortran_to_aviary().Related Issues
Backwards incompatibilities
None
New Dependencies
None